Fix CI Figshare flakiness with retry logic and data caching#56
Merged
iahncajigas merged 1 commit intomainfrom Mar 11, 2026
Merged
Fix CI Figshare flakiness with retry logic and data caching#56iahncajigas merged 1 commit intomainfrom
iahncajigas merged 1 commit intomainfrom
Conversation
Two complementary fixes for transient HTTP 403 errors from Figshare that were causing notebook-changed-pr CI failures: 1. Add exponential-backoff retry (4 attempts) to _http_get() in data_manager.py for 403/429/5xx errors and network failures. 2. Cache the example data directory across CI runs using actions/cache in all notebook jobs (smoke, parity-core, changed-pr, helpfile-full). Uses NSTAT_DATA_DIR env var so the data persists between runs and Figshare is only contacted when the cache is cold. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_http_get()for 403/429/5xx errorsactions/cachein all 4 notebook jobsNSTAT_DATA_DIRenv var to direct data to a cacheable pathThis eliminates the transient
notebook-changed-prfailures caused by Figshare returning HTTP 403 to GitHub Actions IPs.Test plan
test_datasets.pypasses locally_http_get()works correctly for normal Figshare API requestsnstat-example-data-v1can be bumped if the dataset changes🤖 Generated with Claude Code